search

NemesisRE / kiosk-mode

🙈 Hides the Home Assistant header and/or sidebar
MIT License
414 stars 17 forks source link

Remove local getPromosableElement utility #299

Closed elchininet closed 3 weeks ago

elchininet commented 3 weeks ago

This pull request removes the getPromisableElement utility and replace it by the getPromisableResult utility from get-promisable-result. This removes some uncovered branches from the end-to-end tests and slightly increases the coverage from 84.67% to 85.51%.

image
elchininet commented 3 weeks ago

@NemesisRE, If you register the repo in Coveralls I can make the proper changes to start showing a coverage badge in the README of the repo. 85% is a good level to start showing in a badge 🙂

NemesisRE commented 3 weeks ago

I have registered the repo and added the token as secret 😄

elchininet commented 3 weeks ago

added the token as secret

I think that it is not necessary if we use the Coveralls action, but good to have it there just in case we need it. Just make sure that this is enabled in Settings > Code and automation > Actions > General

image