search

NemesisRE / kiosk-mode

🙈 Hides the Home Assistant header and/or sidebar
MIT License
414 stars 17 forks source link

Upload the coverage report to Coveralls #302

Closed elchininet closed 3 weeks ago

elchininet commented 3 weeks ago

This pull request uploads the coverage report to Coveralls using the coverallsapp Github action and adds a coverage badge to the README.

elchininet commented 3 weeks ago

@NemesisRE, coveralls is already set up in this pull request (it is now in the list of checks), but for some reason it is not commenting in the pull request with the coverage information. Is this option already set?

image

NemesisRE commented 3 weeks ago

The option is set including the checkbox at the bottom cause it was checked in your last screenshot

elchininet commented 3 weeks ago

The option is set including the checkbox at the bottom cause it was checked in your last screenshot

The checkbox is not needed, only the radio button. I need to check what else is needed apart from that.

elchininet commented 3 weeks ago

Maybe comments are added after the coverage from master is taken (coveralls comments are a comparison of the master coverage with the pull request coverage). So, let's merge this is first.

elchininet commented 3 weeks ago

@NemesisRE, Also, when the coverage from master is generated, add the test and coveralls status checks to avoid merging a merge request if these two jobs are not successful.

image
elchininet commented 3 weeks ago

Maybe comments are added after the coverage from master is taken (coveralls comments are a comparison of the master coverage with the pull request coverage). So, let's merge this is first.

Yes, this was the issue. The Coveralls bot is already commenting on pull requests.