search

Nemirtingas / ingame_overlay

GNU General Public License v3.0
14 stars 4 forks source link

[Vulkan] Prefer dedicated GPUs first #12

Closed otavepto closed 4 months ago

otavepto commented 4 months ago

The purpose of this change is just to give priority to dedicated GPUs first over integrated ones. Feel completely free to close/reject this PR if you don't want this change.

Nemirtingas commented 4 months ago

Hi, this is useless here because the device is not used. This code is just here to have a way to obtain the internal pointers to the Vulkan driver. Unless you have a reason to use a dedicated GPU to detect Vulkan, I don't think it will affect the detection. It is destroyed 4 lines after its creation here: https://github.com/Nemirtingas/ingame_overlay/blob/42e38e226001fc8355b2f59679c2d5bd5ba313b2/src/windows/Renderer_Detector.cpp#L806-L814

otavepto commented 4 months ago

Oh! I didn't notice that honestly 😄 sorry.