search

Nemocas / AbstractAlgebra.jl

Generic abstract algebra functionality in pure Julia (no C dependencies)
https://nemocas.github.io/AbstractAlgebra.jl/dev/index.html
Other
155 stars 60 forks source link

Add `hash` for SparsePoly #1691

Closed lgoettgens closed 2 months ago

lgoettgens commented 2 months ago

Resolves one issue described in https://github.com/Nemocas/AbstractAlgebra.jl/issues/1689.

Note that this still not fulfils the contract that == objects have the same hash due to the ad-hoc comparisons to the base ring and to Int etc. But since this is the same case for "normal" polys, I would ignore this.

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 86.90%. Comparing base (9c828f7) to head (a7ee78f). Report is 1 commits behind head on master.

Files Patch % Lines
src/generic/SparsePoly.jl 0.00% 6 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1691 +/- ## ========================================== - Coverage 87.34% 86.90% -0.45% ========================================== Files 116 116 Lines 29713 29693 -20 ========================================== - Hits 25954 25805 -149 - Misses 3759 3888 +129 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.