Nemocas / AbstractAlgebra.jl

Generic abstract algebra functionality in pure Julia (no C dependencies)
https://nemocas.github.io/AbstractAlgebra.jl/dev/index.html
Other
163 stars 63 forks source link

Revert "Fix `@alias` test on nightly (#1612)" #1716

Open lgoettgens opened 4 months ago

lgoettgens commented 4 months ago

Reverts #1612.

The underlying issue has been fixed in https://github.com/JuliaLang/julia/pull/54499 and should be available in tomorrows nightly and 1.11.0-beta2.

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 87.42%. Comparing base (6b230ed) to head (00bf708). Report is 3 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1716 +/- ## ========================================== + Coverage 87.35% 87.42% +0.06% ========================================== Files 117 117 Lines 29824 30066 +242 ========================================== + Hits 26053 26284 +231 - Misses 3771 3782 +11 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

thofma commented 4 months ago

Which tomorrow did you mean?

lgoettgens commented 4 months ago

The failure seems to have changed. I need to investigate further

lgoettgens commented 3 months ago

https://github.com/JuliaLang/julia/pull/54499 is only semi fixing this, see https://github.com/JuliaLang/julia/issues/54664