search

Nemocas / AbstractAlgebra.jl

Generic abstract algebra functionality in pure Julia (no C dependencies)
https://nemocas.github.io/AbstractAlgebra.jl/dev/index.html
Other
163 stars 63 forks source link

Remove self-qualified accesses #1726

Closed lgoettgens closed 3 months ago

lgoettgens commented 3 months ago

Some refactoring found using ExplicitImports.jl

In most cases, the removed qualification was used inconsistently in the surrounding code anyway.

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 93.75000% with 1 line in your changes missing coverage. Please review.

Project coverage is 87.33%. Comparing base (c7150f4) to head (dede782).

Files Patch % Lines
src/Matrix.jl 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1726 +/- ## ======================================= Coverage 87.33% 87.33% ======================================= Files 117 117 Lines 29775 29775 ======================================= Hits 26004 26004 Misses 3771 3771 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

fingolfin commented 3 months ago

Discussed this in triage and decided that we should keep the explicit Generic.

lgoettgens commented 3 months ago

I just re-added the Generic.