Closed wbhart closed 5 years ago
It's a general principal that polynomials are not suitable for map
It seems the consensus is reached on this point. map_coeffs
looks fine, it just feels that change_base_ring
would be redundant with it. Aren't all rings supposed to be callable? Then all uses of map_coeffs
look like they can be handled by map_coeffs
(or whatever other map_*
applicable for the specific object).
Is change_base_ring
used by something for something else than matrices and polynomials? To continue with the point above, change_base_ring
could be superseded by map_coeffs
for polynomials, and by matrix(::Ring, ::MatrixElem)
for matrices.
Yes, ideals, modules, fractions and any number of other things. Anything that has a base ring.
It's fine as it is.
Should this now be closed?
See edict 1 here:
https://docs.julialang.org/en/v1/manual/style-guide/index.html#Write-functions-with-argument-ordering-similar-to-Julia-Base-1
(assuming the documentation and convention doesn't change before you look at it).