search

Nemocas / Nemo.jl

Julia bindings for various mathematical libraries (including flint2)
http://nemocas.github.io/Nemo.jl/
Other
176 stars 57 forks source link

Revert "Revert "QQBar: construct from any Integer or Complex value"" #1725

Closed lgoettgens closed 2 months ago

lgoettgens commented 2 months ago

Reverts Nemocas/Nemo.jl#1723, and thus relands #1702.

This won't work until https://github.com/Nemocas/Nemo.jl/issues/1722 is resolved.

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 84.87%. Comparing base (4beb832) to head (92d2a73). Report is 1 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1725 +/- ## ========================================== - Coverage 84.90% 84.87% -0.04% ========================================== Files 95 95 Lines 37290 37286 -4 ========================================== - Hits 31660 31645 -15 - Misses 5630 5641 +11 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

lgoettgens commented 2 months ago

Restarted CI. If neither @fingolfin nor @thofma objects to https://github.com/Nemocas/Nemo.jl/issues/1722#issuecomment-2084867522, we can merge this once CI is happy.