Nemocas / Nemo.jl

Julia bindings for various mathematical libraries (including flint2)
http://nemocas.github.io/Nemo.jl/
Other
176 stars 57 forks source link

Add & fix some conversions from Irrational to our types #1727

Closed fingolfin closed 2 months ago

fingolfin commented 2 months ago

In some cases the wrong precision was used, or a call gave an outright error.

This is missing tests, but then it also has been sitting on my disk for several weeks now. So if it is a PR, at least I won't forget about it.

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 6.66667% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 84.91%. Comparing base (22e3908) to head (5475b04).

Files Patch % Lines
src/arb/Real.jl 0.00% 7 Missing :warning:
src/arb/arb.jl 0.00% 6 Missing :warning:
src/calcium/ca.jl 50.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1727 +/- ## ========================================== - Coverage 84.93% 84.91% -0.03% ========================================== Files 95 95 Lines 37235 37245 +10 ========================================== + Hits 31627 31628 +1 - Misses 5608 5617 +9 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.