search

Nemocas / Nemo.jl

Julia bindings for various mathematical libraries (including flint2)
http://nemocas.github.io/Nemo.jl/
Other
187 stars 58 forks source link

Use terse and is_terse from AbstractAlgebra #1728

Closed fingolfin closed 5 months ago

fingolfin commented 5 months ago

This requires a new AA release

codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 83.33333% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 84.88%. Comparing base (1313283) to head (a276f04).

Files Patch % Lines
src/embedding/EmbeddingTypes.jl 50.00% 2 Missing :warning:
src/flint/flint_puiseux_series.jl 50.00% 2 Missing :warning:
src/flint/qadic.jl 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1728 +/- ## ========================================== + Coverage 84.87% 84.88% +0.01% ========================================== Files 95 95 Lines 37289 37289 ========================================== + Hits 31648 31652 +4 + Misses 5641 5637 -4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

fingolfin commented 5 months ago

Rebased.

And I didn't miss test/flint/fq_default_extended-test.jl, I deliberately did not touch it, as I have no idea how to combine terse with sprint. And it also seems to be testing an odd mix between "supercompact" and "detailed" printing mode. Someone else should figure that one out and resolve it

lgoettgens commented 5 months ago

Rebased.

And I didn't miss test/flint/fq_default_extended-test.jl, I deliberately did not touch it, as I have no idea how to combine terse with sprint. And it also seems to be testing an odd mix between "supercompact" and "detailed" printing mode. Someone else should figure that one out and resolve it

I think I got a trivial change, inspired by flint/fmpq-test.jl.