search

Nemocas / Nemo.jl

Julia bindings for various mathematical libraries (including flint2)
http://nemocas.github.io/Nemo.jl/
Other
176 stars 57 forks source link

Added arg-too-big checks for primorial & fibonacci #1732

Closed JohnAAbbott closed 2 months ago

JohnAAbbott commented 2 months ago

Changed the errors to OverflowError similar to what Julia's factorial does, but different from what Oscar/Nemo did up to now -- breaking change? I know it is not necessary to specify the function name in the error mesg (though InexactError does precisely that); however I think it is more helpful to the user...

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 84.93%. Comparing base (ccf389e) to head (90c6987). Report is 1 commits behind head on master.

:exclamation: Current head 90c6987 differs from pull request most recent head 7674a4d. Consider uploading reports for the commit 7674a4d to get more accurate results

Files Patch % Lines
src/flint/fmpz.jl 50.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1732 +/- ## ========================================== - Coverage 84.94% 84.93% -0.01% ========================================== Files 95 95 Lines 37237 37239 +2 ========================================== - Hits 31631 31629 -2 - Misses 5606 5610 +4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

thofma commented 2 months ago

I have not checked the numbers, but looks good, thanks! Also pretty future-proof in case we will have 128 bit systems :)

thofma commented 2 months ago

Should be added to the new "breaking" release.