search

Nemocas / Nemo.jl

Julia bindings for various mathematical libraries (including flint2)
http://nemocas.github.io/Nemo.jl/
Other
187 stars 58 forks source link

Add base_ring_type methods, remove redundant base_ring methods #1735

Closed fingolfin closed 5 months ago

fingolfin commented 5 months ago

Also fix the base_ring for QQBar

codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 18.75000% with 26 lines in your changes are missing coverage. Please review.

Project coverage is 84.91%. Comparing base (ccf389e) to head (0f62cfb).

Files Patch % Lines
src/flint/flint_puiseux_series.jl 0.00% 2 Missing :warning:
src/flint/padic.jl 0.00% 2 Missing :warning:
src/antic/nf_elem.jl 0.00% 1 Missing :warning:
src/arb/Complex.jl 0.00% 1 Missing :warning:
src/arb/Real.jl 0.00% 1 Missing :warning:
src/arb/acb.jl 50.00% 1 Missing :warning:
src/arb/arb.jl 50.00% 1 Missing :warning:
src/calcium/ca.jl 50.00% 1 Missing :warning:
src/calcium/qqbar.jl 50.00% 1 Missing :warning:
src/flint/fmpq.jl 0.00% 1 Missing :warning:
... and 14 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1735 +/- ## ========================================== - Coverage 84.94% 84.91% -0.04% ========================================== Files 95 95 Lines 37237 37241 +4 ========================================== - Hits 31631 31623 -8 - Misses 5606 5618 +12 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.