search

Nemocas / Nemo.jl

Julia bindings for various mathematical libraries (including flint2)
http://nemocas.github.io/Nemo.jl/
Other
176 stars 57 forks source link

Conform with Julia v1.12.X's definition of gcdx #1739

Closed albinahlback closed 2 months ago

albinahlback commented 2 months ago

Solves #1734.

Perhaps wait to merge until the first release candidate of v1.12.0 is released?

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 84.89%. Comparing base (09c3bef) to head (4d8ab9f). Report is 5 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1739 +/- ## ========================================== - Coverage 84.92% 84.89% -0.03% ========================================== Files 95 95 Lines 37245 37255 +10 ========================================== - Hits 31629 31627 -2 - Misses 5616 5628 +12 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

albinahlback commented 2 months ago

I checked the number based off of base/version_git.sh from the Julia source code. Should be good to go!