Closed joschmitt closed 1 month ago
Attention: Patch coverage is 90.19608%
with 20 lines
in your changes are missing coverage. Please review.
Project coverage is 85.32%. Comparing base (
746d57a
) to head (9c5b8e7
).
Files | Patch % | Lines |
---|---|---|
src/flint/qadic.jl | 88.70% | 14 Missing :warning: |
src/Deprecations.jl | 0.00% | 3 Missing :warning: |
src/flint/padic.jl | 95.45% | 3 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I think I have now everything we discussed.
Looks good, let's discuss the Hecke breakage tomorrow.
This is good to go from my side. It would be good to have a patch release with this, so that I can use it in Hecke.
Very good, thanks
HeckeMoreStuff
to the correct file + some testspadic_field
andqadic_field
where the precision is a keyword argumentprecision
keyword arguments to all constructors which take exact inputprime_field
(should never have been called like that) orlift(::PadicFieldElem)
(lifts to ZZ, so one should calllift(ZZ, ...)
) + more.