Nemocas / Nemo.jl

Julia bindings for various mathematical libraries (including flint2)
http://nemocas.github.io/Nemo.jl/
Other
176 stars 57 forks source link

p-adics done right #1746

Closed joschmitt closed 1 month ago

joschmitt commented 2 months ago
codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 90.19608% with 20 lines in your changes are missing coverage. Please review.

Project coverage is 85.32%. Comparing base (746d57a) to head (9c5b8e7).

Files Patch % Lines
src/flint/qadic.jl 88.70% 14 Missing :warning:
src/Deprecations.jl 0.00% 3 Missing :warning:
src/flint/padic.jl 95.45% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1746 +/- ## ========================================== + Coverage 85.09% 85.32% +0.22% ========================================== Files 95 95 Lines 36917 36903 -14 ========================================== + Hits 31416 31487 +71 + Misses 5501 5416 -85 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

joschmitt commented 2 months ago

I think I have now everything we discussed.

thofma commented 1 month ago

Looks good, let's discuss the Hecke breakage tomorrow.

joschmitt commented 1 month ago

This is good to go from my side. It would be good to have a patch release with this, so that I can use it in Hecke.

thofma commented 1 month ago

Very good, thanks