Closed albinahlback closed 1 month ago
Attention: Patch coverage is 40.74074%
with 16 lines
in your changes are missing coverage. Please review.
Project coverage is 84.80%. Comparing base (
69f5c85
) to head (63fa792
).
Files | Patch % | Lines |
---|---|---|
src/flint/FlintTypes.jl | 31.25% | 11 Missing :warning: |
src/Nemo.jl | 44.44% | 5 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Seems to not break anything for flint 3.1. No clue if this works for flint#master, since it is not tested.
Due to https://github.com/flintlib/flint/pull/1964:
The GMP-state in a FLINT random context structure will no longer be expanded inside the struct, but rather a pointer to it. Hence, make Nemo compatible with this.
Do not use
flint_rand_alloc
andflint_rand_free
for allocating the FLINT random context structure. This is in order to be able to use the same code for the new version of FLINT as well as the old version.Use the new symbol names for the FLINT random functions if they are available. This is checked during the initialization of Nemo, where we check for the new symbol
flint_rand_init
.