search

Nemocas / Nemo.jl

Julia bindings for various mathematical libraries (including flint2)
http://nemocas.github.io/Nemo.jl/
Other
176 stars 57 forks source link

Apply formatter #1752

Closed joschmitt closed 1 month ago

joschmitt commented 1 month ago

I ran the Julia formatter on everything. We can of course merge other pull requests first since this one is easier to update. We can also discuss/bikeshed whether people actually like the formatting defaults. I would also be happy with just consistent indentation everywhere.

Closes #1751.

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 57.46790% with 1888 lines in your changes are missing coverage. Please review.

Project coverage is 84.81%. Comparing base (1c99647) to head (9dea529).

Files Patch % Lines
src/HeckeMoreStuff.jl 3.38% 656 Missing :warning:
src/HeckeMiscPoly.jl 7.17% 220 Missing :warning:
src/HeckeMiscMatrix.jl 25.49% 190 Missing :warning:
src/arb/ArbTypes.jl 49.71% 175 Missing :warning:
src/HeckeMiscInteger.jl 35.63% 112 Missing :warning:
src/antic/nf_elem.jl 74.41% 98 Missing :warning:
src/HeckeMiscFiniteField.jl 43.44% 69 Missing :warning:
src/arb/ComplexPoly.jl 79.45% 53 Missing :warning:
src/arb/Real.jl 87.87% 52 Missing :warning:
src/Nemo.jl 39.28% 51 Missing :warning:
... and 7 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1752 +/- ## ======================================= Coverage 84.81% 84.81% ======================================= Files 95 95 Lines 36968 37000 +32 ======================================= + Hits 31354 31382 +28 - Misses 5614 5618 +4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

thofma commented 1 month ago

I welcome the change to use two spaces, but the automatic things are suboptimal, see my comments.

thofma commented 1 month ago

But now many lines are longer than 80 characters. The hand-formatted new lines in argument lists / ccalls are now gone.

joschmitt commented 1 month ago

But now many lines are longer than 80 characters. The hand-formatted new lines in argument lists / ccalls are now gone.

Yes. Exactly. That's why I had the join_lines_based_on_source in my second attempt.

joschmitt commented 1 month ago

I have the feeling that this automatic formatting is not converging... is anybody using this functionality in real life?