Closed joschmitt closed 4 months ago
Attention: Patch coverage is 58.26287%
with 1629 lines
in your changes are missing coverage. Please review.
Project coverage is 84.81%. Comparing base (
1c99647
) to head (068c1f9
).
Files | Patch % | Lines |
---|---|---|
src/HeckeMoreStuff.jl | 3.39% | 654 Missing :warning: |
src/HeckeMiscPoly.jl | 7.20% | 219 Missing :warning: |
src/HeckeMiscMatrix.jl | 25.59% | 189 Missing :warning: |
src/HeckeMiscInteger.jl | 34.88% | 112 Missing :warning: |
src/antic/nf_elem.jl | 75.27% | 91 Missing :warning: |
src/HeckeMiscFiniteField.jl | 43.80% | 68 Missing :warning: |
src/arb/acb_poly.jl | 77.13% | 51 Missing :warning: |
src/arb/ComplexPoly.jl | 78.16% | 50 Missing :warning: |
src/Nemo.jl | 43.47% | 39 Missing :warning: |
src/arb/RealPoly.jl | 80.52% | 37 Missing :warning: |
... and 9 more |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Good enough for me. The low coverage is frightening, but let's ignore this for now.
@joschmitt do you want this merged now, or only after #1746 and #1754 are resolved?
@joschmitt do you want this merged now, or only after #1746 and #1754 are resolved?
Let's merge this. It's never gonna be painless.
I found the magical bash/vim one-liner that adjusts the indentation to two spaces in all files.
Fixes #1751. Closes #1752 (that is, I leave other formatting rules to somebody else)