search

Nemocas / Nemo.jl

Julia bindings for various mathematical libraries (including flint2)
http://nemocas.github.io/Nemo.jl/
Other
187 stars 58 forks source link

Tidy up `HeckeMiscFiniteFields.jl` #1754

Closed joschmitt closed 4 months ago

joschmitt commented 4 months ago

I procrastinated a bit yesterday and tidied up HeckeMiscFiniteFields.jl. This moves functions to the correct file and adds tests. Some functions were duplicates. There is just one function left in this file which needs Hecke to work...

The OSCAR and Hecke tests work locally for me.

I think this is the smallest of these Hecke* files, but it's a start.

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 98.36066% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 85.10%. Comparing base (7a72976) to head (e2bcb5f).

Files Patch % Lines
src/HeckeMiscFiniteField.jl 0.00% 1 Missing :warning:
src/embedding/EmbeddingTypes.jl 88.88% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1754 +/- ## ========================================== + Coverage 84.81% 85.10% +0.28% ========================================== Files 95 95 Lines 36970 36917 -53 ========================================== + Hits 31357 31419 +62 + Misses 5613 5498 -115 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.