Closed lgoettgens closed 4 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 85.46%. Comparing base (
b04719f
) to head (f52e45e
). Report is 1 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Fine by me. But this comes from Hecke, so I wonder if @fieker or @thofma perhaps need(ed) it for an application?
This is indeed used in Hecke in https://github.com/thofma/Hecke.jl/blob/d5a199e6aba6d90ec80922f22eef2ceb2492b4d6/src/RieSrf/Theta.jl#L79 but I still don't think this is a good name. It would be great to hear something from @thofma @fieker @JHanselman
It is the Frobenius norm and is equal to LinearAlgebra.norm
. I don't see the problem with the name.
Alright, may I then suggest instead to widen the signature to at least Acb, Complex, Arb and Real (matrices)? And I would add some proper test then
Sure, that sounds good.
This is the only matrix type with a norm function, and this is not even a vector-norm induced matrix norm, so not what most people want.
Let's see if this is used downstream, anyway we should wait for the next minor release.