Nemocas / Nemo.jl

Julia bindings for various mathematical libraries (including flint2)
http://nemocas.github.io/Nemo.jl/
Other
187 stars 58 forks source link

Remove `norm(::ArbMatrix)` #1764

Closed lgoettgens closed 4 months ago

lgoettgens commented 4 months ago

This is the only matrix type with a norm function, and this is not even a vector-norm induced matrix norm, so not what most people want.

Let's see if this is used downstream, anyway we should wait for the next minor release.

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 85.46%. Comparing base (b04719f) to head (f52e45e). Report is 1 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1764 +/- ## ========================================== - Coverage 85.48% 85.46% -0.03% ========================================== Files 95 95 Lines 36923 36921 -2 ========================================== - Hits 31565 31554 -11 - Misses 5358 5367 +9 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

fingolfin commented 4 months ago

Fine by me. But this comes from Hecke, so I wonder if @fieker or @thofma perhaps need(ed) it for an application?

lgoettgens commented 4 months ago

This is indeed used in Hecke in https://github.com/thofma/Hecke.jl/blob/d5a199e6aba6d90ec80922f22eef2ceb2492b4d6/src/RieSrf/Theta.jl#L79 but I still don't think this is a good name. It would be great to hear something from @thofma @fieker @JHanselman

thofma commented 4 months ago

It is the Frobenius norm and is equal to LinearAlgebra.norm. I don't see the problem with the name.

lgoettgens commented 4 months ago

Alright, may I then suggest instead to widen the signature to at least Acb, Complex, Arb and Real (matrices)? And I would add some proper test then

thofma commented 4 months ago

Sure, that sounds good.