search

Nemocas / Nemo.jl

Julia bindings for various mathematical libraries (including flint2)
http://nemocas.github.io/Nemo.jl/
Other
176 stars 57 forks source link

Misc cleanup #1770

Closed fingolfin closed 1 month ago

fingolfin commented 1 month ago

For further details please refer to the respective commit messages.

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 52.22222% with 43 lines in your changes missing coverage. Please review.

Project coverage is 85.59%. Comparing base (2c69d79) to head (0d0b53e).

:exclamation: Current head 0d0b53e differs from pull request most recent head 5887a5a

Please upload reports for the commit 5887a5a to get more accurate results.

Files Patch % Lines
src/flint/fmpz_mat.jl 52.22% 43 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1770 +/- ## ========================================== - Coverage 85.80% 85.59% -0.21% ========================================== Files 95 95 Lines 36870 36905 +35 ========================================== - Hits 31636 31590 -46 - Misses 5234 5315 +81 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

lgoettgens commented 1 month ago

Unfortunately we have conflicts with https://github.com/Nemocas/Nemo.jl/pull/1768

fingolfin commented 1 month ago

rebased. And I've filed #1773 for reduce_mod vs. mod, we don't need to settle it in this PR -- at least now the code for both is next to each other, making the duplication a bit more "obvious"

lgoettgens commented 1 month ago

rebased. And I've filed #1773 for reduce_mod vs. mod, we don't need to settle it in this PR -- at least now the code for both is next to each other, making the duplication a bit more "obvious"

Thanks for both!