search

Nemocas / Nemo.jl

Julia bindings for various mathematical libraries (including flint2)
http://nemocas.github.io/Nemo.jl/
Other
176 stars 57 forks source link

Fix (P/Q)adicFieldElem printing in poly ring elems #1774

Closed lgoettgens closed 1 month ago

lgoettgens commented 1 month ago

Resolves https://github.com/thofma/Hecke.jl/issues/1535 in a similar way to https://github.com/Nemocas/AbstractAlgebra.jl/pull/1667. The same issue was there for PadicFieldElem as well, and the tests for this were easier to adapt. Let's hope that the wrong behavior is not doctested downstream.

lgoettgens commented 1 month ago

closed in favor of https://github.com/thofma/Hecke.jl/pull/1536

thofma commented 1 month ago

Hm, the types here and in https://github.com/thofma/Hecke.jl/pull/1536 have nothing in common I think?

lgoettgens commented 1 month ago

Yeah, I got confused by an older Hecke version and mismatched QadicRingElem with QadicFieldElem

lgoettgens commented 1 month ago

So this PR doesn't change anything with regards to fixing thofma/Hecke.jl#1535 and is just an unnecessary change