try fixing master names nonsense changes

Nemocas / Nemo.jl

Julia bindings for various mathematical libraries (including flint2)

http://nemocas.github.io/Nemo.jl/

Other

187 stars 58 forks source link

try fixing master names nonsense changes #1800

Closed thofma closed 3 months ago

thofma commented 3 months ago

Not working yet. At the moment I get

Failed to precompile Nemo [2edaba10-b0f1-5616-af89-8c11ac63239a] to "/bla/compiled/v1.12/Nemo/jl_bWSCtB".
ERROR: LoadError: UndefVarError: `EuclideanRingResidueRingElem` not defined in `Nemo`

although

julia> :EuclideanRingResidueRingElem in names(AbstractAlgebra; usings_explicit = true, non_public = true)
true

Not sure what the problem is. Maybe something to do with Generic?

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 85.97%. Comparing base (bd980c9) to head (53bd5b7). Report is 1 commits behind head on master.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #1800 +/- ## ========================================== + Coverage 85.94% 85.97% +0.02% ========================================== Files 95 95 Lines 36417 36417 ========================================== + Hits 31299 31308 +9 + Misses 5118 5109 -9 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

thofma commented 3 months ago

Maybe it is a problem with https://github.com/JuliaLang/julia/pull/54659. Apparently it should not have changed the old behavior. I will open an issue.

thofma commented 3 months ago

Arg, we are now getting all the symbols in AbstractAlgebra, that every module automatically has, e.g. include, pkgdir,...

thofma commented 3 months ago

OK, let's hope julia folks consider this a bug.

lgoettgens commented 3 months ago

The julia commit has been reverted in https://github.com/JuliaLang/julia/pull/54959, so Nemo should work again once the next nightly is available (in a few hours).