Closed fingolfin closed 1 week ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 85.96%. Comparing base (
784c28a
) to head (4fc5241
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Can someone (@fingolfin @thofma) un-require the nightly CI job until https://github.com/oscar-system/Oscar.jl/issues/3882 is resolved?
Huh, from my POV the tests against Julia nightly should never be required. Changed it.
is_zero_row should be done for ZZ and ZZ mod, but in a useful way. The removed implementation is highly non-optimal, this can be sped up by a factor of 10 or so
although it is probably non critical, timewise
There is actually a generic function in https://github.com/Nemocas/AbstractAlgebra.jl/blob/762eab1920547d2e4c3f3e77a4976fff119bf206/src/Matrix.jl#L247-L254, that delegates to a Nemo-backed is_zero_entry
. Thus Max's removal is essentially no change at all.
the point is that is_zero_row for ZZ should be done via
With the addition of the new is_zero_entry method, the removed is_zero_row methods are not faster than the generic one. Also add some tests, which were also used for benchmarking, together with