Nemocas / Nemo.jl

Julia bindings for various mathematical libraries (including flint2)
http://nemocas.github.io/Nemo.jl/
Other
187 stars 58 forks source link

Faster `is_zero_row` for Nemo matrices #1805

Closed lgoettgens closed 1 week ago

lgoettgens commented 3 months ago

the point is that is_zero_row for ZZ should be done via

Originally posted by @fieker in https://github.com/Nemocas/Nemo.jl/issues/1801#issuecomment-2191295771

fingolfin commented 3 months ago

Here are some steps towards that:

  1. Replace ccalls in mat_entry_ptr methods with direct pointer computations, e.g. as done in PR #1807
  2. Replace ccalls in various test functions with more direct access, e.g. as done in PR #1808 -- another e.g. also is_zero etc. for QQFieldElem could be im

My two PRs mark the way, but similar techniques should be applied to many other flint wrappers. Perhaps @aaruni96 can work on that after the Begehung (we'll talk about it when he's back in Kaiserslautern)

fingolfin commented 1 week ago

With https://github.com/Nemocas/AbstractAlgebra.jl/pull/1802 added to the mix, I really think we can close this.