search

Nemocas / Nemo.jl

Julia bindings for various mathematical libraries (including flint2)
http://nemocas.github.io/Nemo.jl/
Other
178 stars 57 forks source link

Turn zzModRing & ZZModRing into ResidueRing subtypes #1819

Open fingolfin opened 3 weeks ago

fingolfin commented 3 weeks ago

Since the element types of these ring types are subtypes of ResElem, the rings should be subtypes of ResidueRing. Otherwise some generic code gets confused (notably check_parent for ResElem).

This lead to a wrong error in the OSCAR book's introduction notebook.

joschmitt commented 3 weeks ago

I'm sorry! Obviously, I didn't check this carefully enough yesterday evening.

fingolfin commented 3 weeks ago

Hrm, this changes messes up the rand delegation, which already is a mess in itself... sigh.