Nenotriple / R-ESRGAN-AnimeVideo-UI

reav-ui - Upscale videos using R-ESRGAN
59 stars 6 forks source link

App window height exceeds desktop height #17

Closed the-liquid-metal closed 5 months ago

the-liquid-metal commented 5 months ago

My desktop is 1920x1080.

image

Nenotriple commented 5 months ago

I'm guessing your desktop scaling options are greater than 100%, because the app window height is set to 715px, so it should fit just fine.

You can check your scaling settings by going to Windows Settings and searching for “Make everything bigger”. If your scaling is set to more than 100%, try setting it down to 100%. This should make the window fully visible on your desktop.

Thank you for bringing this to my attention, but I don’t have the time to work on this issue at the moment. I hope this suggestion helps you.

the-liquid-metal commented 5 months ago

I'm guessing your desktop scaling options are greater than 100%, because the app window height is set to 715px, so it should fit just fine.

Yes it is (150%). Without it, i am struggling to read my screen. Moreover, with this zoom level, your app looks normal to me. Is there any way to fix this?

Nenotriple commented 5 months ago

Unfortunately, the app is coded not to be resizable because it's much easier/faster to develop the interface. If you were to resize the window height, it would just squish the buttons out of view, and that wouldn't fix anything.

The only thing I can really do is restructure the UI so it's wide instead of tall, but that's not an entirely simple or quick process. Sorry, but I don't have any real solution that would "solve" this for you.


You might find the Windows magnifier useful when using the app at 100% scale. You can enable it with the Windows logo key and Plus sign (+).

Or maybe you can just use the app normally at 150% scale? It doesn't look like any controls are cutoff.

the-liquid-metal commented 5 months ago

Or maybe you can just use the app normally at 150% scale? It doesn't look like any controls are cutoff.

This is not always true. Somehow, the app displays the lowest button. But most of the time these buttons are not visible.

image

but that's not an entirely simple or quick process. Sorry, but I don't have any real solution that would "solve" this for you.

How about merging "single image upscale" and "batch upscale"? Many Real-ESRGAN GUI applications I've found are designed like this.

the-liquid-metal commented 5 months ago

image IMHO, The jumbo "Auto Rezise frames" text is less important, and can be removed so that the lowest text can be displayed entirely. Its tooltip can be merged with both controls below,

the-liquid-metal commented 5 months ago

How about merging "single image upscale" and "batch upscale"? Many Real-ESRGAN GUI applications I've found are designed like this.

Even further, all four functionalities can be combined:

This will save a lot of space and more intuitive.

Nenotriple commented 5 months ago

I really appreciate your ideas. Eventually, I would like to make the interface cleaner and more intuitive.

I've looked at it some more, and I think the easiest compromise is to remove the info text at the top of the UI. Almost everything is printed on the console anyway, so there isn't much lost. It reduces the window height from 715px, to 490px. This should come out to something like 735px at 150% scale.

You can download v1.18.b from here.

You can use this release by dropping the v1.18.b executable in the same folder as the v1.18 executable.

This should make the window much shorter:

Untitled3

Untitled

Untitled2

v1.18.b note: I just commented out the "pack" function call for the label frame. This means that all the widgets are still being created and updated, but not displayed. Then I reduced the window height to 490px.

the-liquid-metal commented 5 months ago

Thanks for the quick solution. That's all I need at the moment, as I use this app only for evaluation purposes, not as an everyday tool (yet).

Please consider my design proposal if you have plans to refactor this app.

One more suggestion: replace the console window with a dedicated "log" tab, alongside the "video" and "images" tabs.