Open TobiNeo opened 2 months ago
Are these designs reflective of the requirement ?
Hi Pratik,
Thanks for sketching a prototype and asking for a review before you start coding. And yes, this looks good! All the best for the implementation and feel free to reach out if you have any questions.
UPDATE: These are some of the UI implementations. Feedback is welcome:
suggestion: adding an extra optional field "Task (Link)" to the Worklog doctype can help users easily track the task the log is related to and improve UX.
UPDATE: These are some of the UI implementations. Feedback is welcome:
Hi Pratik,
Judging by the screenshots it certainly looks nice, good job :)
- "No log today" alert on checkout without daily log
I just talked to Marius, maybe you can additionally add a link to the page where the user can edit their worklog in the prompt. As it is possible to check out anywhere in the ERP from the header bar, this makes the usability better, as entering the worklog is only one click away if it has been forgotten.
suggestion: adding an extra optional field "Task (Link)" to the Worklog doctype can help users easily track the task the log is related to and improve UX.
This is also a good idea, we were already thinking about creating a connection to the task / project management framework in a second stage. However, feel free to already implement the task linking. Generally, it is nice that you make up your mind and think about additional useful functions - feel free to also do that in future tasks :)
So far so good - considering the next steps, as your first code revision is finished: Please create a pull request and put marius-meissner as reviewer. Then Marius can review the code and afterwards push it to our Dev-ERPNext instance. We will then do some testing from user perspective, and after potential optimizations are done it can be pushed to the staging and then production systems.
If there are any questions feel free to reach out to me again.
Thank you. Yes, that is a good suggestion. I will implement it and then push the changes with Marius as reviewer.
Closed but Continued in: new PR
As discussed in the JF meeting yesterday, please implement the following changes:
The flextime module is currently only used for employee time logging. It would be great to have a textbox on the front page for notes, so that the daily activity can be logged in bullet points:
First layout idea: A box called "Work Log", between "Status" and "Dokumente und Protokolle". For this, we need a new Doctype "Worklog" with the fields "Date", "Employee" and a text field for logging the tasks.
The worklogs should also be compiled in a list view - analog to "Flextime daily status". As this is private date from each employee, there need to be permissions in place to avoid one employee seeing the work logs of another employee. Viewing all should be reserved to people with the "HR Manager" user role.
After the addition is finished, the second step entails appending the contents of the text fields to the bottom of "Flextime daily status" which is compiled every night.
This field should be editable by the employee him/herself, as forgetting to fill the worklog can happen. Also, a reminder to fill the worklog if you check out and the field is empty would be nice to have.