search

Neo23x0 / Raccine

A Simple Ransomware Vaccine
The Unlicense
942 stars 123 forks source link

Added test project #53

Closed Eran-YT closed 3 years ago

Eran-YT commented 3 years ago

Create Raccine-Test and RaccineLib projects: Raccine-Test contains the unit tests RaccineLib contains the source Raccine is the project that build the executable, should contain no business logic (currently does, but needs to be moved) Added an example unit test

mback2k commented 3 years ago

Does GTEST really need to be part of this repository? Can't it be a submodule or an artifact being downloaded on demand?

Eran-YT commented 3 years ago

Does GTEST really need to be part of this repository? Can't it be a submodule or an artifact being downloaded on demand?

I'll try to fix it

Eran-YT commented 3 years ago

Gtest is now consumed via nuget package

Eran-YT commented 3 years ago

@Neo23x0 This is ready for merge

mback2k commented 3 years ago

As far as I can see there are quite a lot of noisy changes in this PR. Is all of this needed? Can the individual commits maybe be squashed in logical steps?

Eran-YT commented 3 years ago

They can be squashed in the merge

Eran-YT commented 3 years ago

Personally I prefer to squash all PR in projects I work on, but that's not my decision here

mback2k commented 3 years ago

You can of course rewrite the history of this PR and then do a force-push to have a clean history before merge.

Eran-YT commented 3 years ago

I rewrote the git history for this PR, is this what you meant?

Neo23x0 commented 3 years ago

Thanks a lot to you two. We've started this as a hacky PoC and now it gets more and more professional.