NeoA11y / SpeakTouch

[WIP] A free software screen reader for Android.
8 stars 0 forks source link

Add dagger hilt #103

Closed Irineu333 closed 10 months ago

Irineu333 commented 10 months ago

Description

I improved the app's dependency injection with dagger hilt.

PatrykMis commented 10 months ago

To be consistent, I added 2 more commits to refactor for Version Catalogs.

Slight offtopic, but buildSrc modules are problematic, thus I had to do a workarround from https://github.com/gradle/gradle/issues/20084. I think that build logic could be safely moved to app module build file. For example, look at https://github.com/chenxiaolong/BCR/blob/master/app/build.gradle.kts

Irineu333 commented 10 months ago

To be consistent, I added 2 more commits to refactor for Version Catalogs.

Slight offtopic, but buildSrc modules are problematic, thus I had to do a workarround from gradle/gradle#20084. I think that build logic could be safely moved to app module build file. For example, look at https://github.com/chenxiaolong/BCR/blob/master/app/build.gradle.kts

I am aware of this limitation of plugins.alias with buildSrc, I believe your solution is ideal. Let's hope they improve this.

Irineu333 commented 10 months ago

@PatrykMis I sent a commit improving context dependencies.

Irineu333 commented 10 months ago

Last change, I swear.