NeoA11y / SpeakTouch

[WIP] A free software screen reader for Android.
8 stars 0 forks source link

Empty edit fields without content are not being announced #109

Closed PatrykMis closed 7 months ago

PatrykMis commented 7 months ago

Describe the bug:

Empty edit fields without label and description are not being announced

To Reproduce:

Open some app with edit fields which are empty, without any description nor label and try to focus them either by touch exploration or gestures. One example app is Pyszne.pl while adding address fields before checkout

Expected behavior

They should be focusable and being announced, even if the one possible thing to announce is only "edit field".

Stack trace (to dev):

More infos:

App version: 1.0.0-DEV Android version: 13, 14 Device: Google Pixel 4, Google Pixel 8

Irineu333 commented 7 months ago

Congratulations on the find.

Irineu333 commented 7 months ago

Do you have several cell phones? Just to test on different devices?

Irineu333 commented 7 months ago

This happens because the app does not focus on nodes without content. To correct this, just consider any edit field inherently readable, in NodeValidator.hasContentToRead, just as we do with any checkable node

PatrykMis commented 7 months ago

Do you have several cell phones? Just to test on different devices?

I have even one more phone to test, three in total.