search

NeoA11y / SpeakTouch

[WIP] A free software screen reader for Android.
8 stars 0 forks source link

App does not work in flutter apps #128

Closed Irineu333 closed 9 months ago

Irineu333 commented 10 months ago

Description

Read the issue.

Fixed issues

Irineu333 commented 9 months ago

I only tested it on Memo, I will test it on more Flutter apps:

Irineu333 commented 9 months ago

@coderabbitai review

coderabbitai[bot] commented 9 months ago

Walkthrough

The updates involve refactoring and enhancing the accessibility and logging features of an Android app. Import statements have been reordered and updated, while the Node class has been expanded with new properties and a logging function. The NodeFilter interface logic has been modified, and NodeValidator has increased access levels and revised function logic. Redundant checks in Reader have been removed, and AccessibilityNodeInfo extensions have been refined with added functionality and removed obsolete methods.

Changes

File Path Change Summary
.../controller/FocusController.kt Reordered imports.
.../controller/SpeechController.kt Updated imports; replaced a logging statement.
.../intercepter/event/FocusInterceptor.kt Added imports; simplified AccessibilityEvent type conditions.
.../model/NodeFilter.kt Modified filter function logic.
.../utils/Node.kt Added imports, properties, and log function.
.../utils/NodeValidator.kt Changed access levels; renamed and adjusted function logic.
.../utils/Reader.kt Removed node validity check.
.../utils/extension/AccessibilityNodeInfo.kt Added import; removed functions; modified performFocus; added getName extension.

Poem

🐇 "In the realm of code, a hop and a skip,
Changes abound, the app's fabric we flip.
Accessibility grows, with each line we commit,
A rabbit's touch, in binary knit." 🌟

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat with CodeRabbit Bot (`@coderabbitai`) - You can directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit ``.` - You can tag CodeRabbit on specific lines of code or entire files in the PR by tagging `@coderabbitai` in a comment. Examples: - `@coderabbitai generate unit tests for this file` - `@coderabbitai modularize this function` - You can tag `@coderabbitai` in a PR comment and ask questions about the PR and the codebase. Use quoted replies to pass the context for follow-up questions. Examples: - `@coderabbitai gather interesting statistics about this repository and render them in a table.` - `@coderabbitai show all the `console.log` statements in this repository.` - `@coderabbitai generate unit tests for the `src/utils.ts` file.` ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - The JSON schema for the configuration file is available [here](https://coderabbit.ai/integrations/coderabbit-overrides.v2.json). - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json` ### CodeRabbit Discord Community Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback.
Irineu333 commented 9 months ago

@coderabbitai resolve I expected more from this tool. The comments are basically: "you changed something, check if it's correct".

coderabbitai[bot] commented 9 months ago

@Irineu333, I apologize if the review comments did not meet your expectations. The intent is to ensure that changes are intentional and correctly implemented, especially when it comes to accessibility and compatibility improvements. If there are specific areas you would like me to focus on or any additional context you can provide, I'd be glad to assist further. Meanwhile, I will resolve all the comments as you requested.

If you encounter any more bugs or areas of concern during your testing on different Flutter apps, please feel free to reach out, and I can help review those changes as well.

:bulb: NOTE The above message was generated in response to the following comment. Please use quote reply to maintain the context of the conversation. @coderabbitai resolve I expected more from this tool. The comments are basically: "you changed something, check if it's correct".