search

NeoApplications / Neo-Backup

backup manager for android
GNU Affero General Public License v3.0
2.37k stars 120 forks source link

[Bug] "Use session installer" should be off on Android 12 or lower #738

Closed shaygover closed 1 year ago

shaygover commented 1 year ago

Description When "Use session installer" is on backup is stuck on the first app. Steps To Reproduce

  1. Leave that setting on
  2. Try to backup
  3. Wait 2 hours
  4. Nothing happens

Expected behavior A backup will happen

System Information(please complete the following information):

hg42 commented 1 year ago

I cannot confirm this... I have an AOSP A10 ROM and it works with session installer. I never had hanging backups.

And there is another bigger point:

The only action, where this setting is used, is restore (which is absolutely logical, because installation happens on restore, not on backup). You can search for pref_enableSessionInstaller, it is used only at one place in the sources, in RestoreAppAction.kt.

How did you test it? Did you switch off session installer and it worked. Did you also switch it on again and it failed again? How often did you try back and forth?

If it is really reproducible, we might think again, though I don't see any way, how this could be related.

shaygover commented 1 year ago

I see. Tested once. Will reopen if I've time to check and it's reproducible.