search

NeoApplications / Neo-Store

An F-Droid client with modern UI and an arsenal of extra features.
GNU General Public License v3.0
2.95k stars 91 forks source link

[Bug] Crash when updating Signal #659

Open h-2 opened 3 weeks ago

h-2 commented 3 weeks ago

Describe the bug

Calyx Repo just updated Signal (finally!). But now NeoStore crashes when trying to download it. This is really annoying, because the current signal version will become unusable in a week.

To Reproduce Steps to reproduce the behavior:

  1. Activate the Calyx Testing Repo
  2. Find Signal
  3. Press install
  4. App crashes during download even if it is kept in foreground

Expected behavior

Shouldn't crash.

Screenshots

Relevant information:

h-2 commented 3 weeks ago

If I select the System-Downloader in the options, it doesnt crash while downloading, but then it fails to verify the signature afterwards.

machiav3lli commented 3 weeks ago

I face neither issues. If the signature fail it could be that you've Signal from another source. Try if disabling signature verification in settings/updates help, if not then you surely have Signal from another source.

That said, if you'd like Signal with timely updates uninstall yours (don't forget to backup) and install Signal-FOSS from TwinHelix's repo.

h-2 commented 3 weeks ago

If the signature fail it could be that you've Signal from another source.

No, I have from Calxy source.

Calyx is aware of the issue, it happens because Signal has rotated their Signing key: https://community.signalusers.org/t/beta-feedback-for-the-upcoming-android-7-10-release/61489/60

This caused problems in the FDroid repo software resulting in a delay of the Signal builds. Those are now fixed and the official F-Droid clients should be able to handle the change. But I was told that they wouldn't be surprised if other clients had problems updating this particular package.

h-2 commented 3 weeks ago

I can confirm that F-Droid basic client is able to successfully upgrade the Signal App from the same Repo that NeoStore failed with.

machiav3lli commented 3 weeks ago

Try if disabling signature verification in settings/updates help, if not then you surely have Signal from another source.

I would've been interested in this point, but it seems you didn't check this (too late, I guess). That said, I'll see what needs to be implemented to support signature rotation.