search

NeoAssist / docker-keepalived

Dockerized keepalived to ease HA in deployments with multiple hosts. Provides failover for Virtual IPs (VIP) to be always online even if a host fails. Initially aimed to help Rancher HA deployments
MIT License
65 stars 37 forks source link

[Request] Add versioning to image for any changes #10

Closed cavemandaveman closed 8 years ago

cavemandaveman commented 8 years ago

We are preparing to use this in production, and it would be nice to have versioned images instead of just "latest".

Something like neoassist/docker-keepalived:1.0.0 or even timestamp versioning like 201610071051 would be fine.

roynasser commented 8 years ago

@cavemandaveman That sounds reasonable... I havent had time to test the latest changes, can you confirm if it is working currently? I can then make a tag to "fix" the current version, even if only as an RC... Thanks for the suggestion!

I have already updated docker hub settings to pull any tags and make them available as differnt versions, and the latest remains on the master branch.

cavemandaveman commented 8 years ago

After the last couple of PRs got merged in, everything looks to be stable to me!

roynasser commented 8 years ago

I'm going to close this as we now have a fixed tag which apparently is working (at least for cavemandaveman)... Further changes will be made on the master and then pushed out as tags for either a stable or RC which should help prevent bugs from surfacing...

One issue I have noticed the docker image isnt fixed, instead its using references to latest and edge versions. This can pose issues when the base image (alpine in this case) has its latest tag updated...