search

NeoGeographyToolkit / StereoPipeline

The NASA Ames Stereo Pipeline is a suite of automated geodesy & stereogrammetry tools designed for processing planetary imagery captured from orbiting and landed robotic explorers on other planets.
Apache License 2.0
479 stars 169 forks source link

nadirpinhole not properly set in camera_solve with camera positions. #248

Open ScottMcMichael opened 5 years ago

ScottMcMichael commented 5 years ago

When --camera-positions is passed in to camera_solve it should automatically use the session "nadirpinhole" but this is not working properly.

oleg-alexandrov commented 5 years ago

Good point. This would assume we are on Earth though, which I guess it is reasonable since we don't play with frame cameras on other planets.

There is also the issue if bundle_adjust assumes a datum when it does the first adjustment, while the cameras are still in an arbitrary coordinate system. Maybe camera_solve should invoke bundle_adjust with the --no-datum flag.

ScottMcMichael commented 5 years ago

I was not able to reproduce this error so it may take extra investigation.