NeoGeographyToolkit / StereoPipeline

The NASA Ames Stereo Pipeline is a suite of automated geodesy & stereogrammetry tools designed for processing planetary imagery captured from orbiting and landed robotic explorers on other planets.
Apache License 2.0
479 stars 169 forks source link

bundle_adjust with num-passes > 1... issue writing final condition files #256

Closed jchollingsworth closed 5 years ago

jchollingsworth commented 5 years ago

If num-passes > 1, but bundle_adjust converges quickly, the final condition files are not written. i.e., after the first pass: No new outliers removed, and the algorithm converged. No more passes are needed. ... then it simply writes the adjust/tsai files, without writing the final condition files (which are useful for using with pc_align).

oleg-alexandrov commented 5 years ago

I put a fix. Now bundle_adjust will save all residual files after each pass since it is not guaranteed to reach the last one. This is some overhead, but normally one calls this tool with maybe two or three passes. Thanks for the report.