search

NeoGeographyToolkit / StereoPipeline

The NASA Ames Stereo Pipeline is a suite of automated geodesy & stereogrammetry tools designed for processing planetary imagery captured from orbiting and landed robotic explorers on other planets.
Apache License 2.0
492 stars 173 forks source link

add nocheck to hiedr2mosaic #303

Closed AndrewAnnex closed 4 years ago

AndrewAnnex commented 4 years ago

adds the flag "--nocheck" to hiedr2mosaic.py to disable check for even number of ccd files

I also fixed some other formatting in hiedr2mosaic.py

rbeyer commented 4 years ago

Thanks for this PR, but I think this can be solved differently.

I didn't notice that check in main() was what you ran into.

I don't think that you need to add a --nocheck because I think that check in main() is actually completely unnecessary (that code doesn't even check for the match CCD as its comment indicates). An odd number of channel files can be given, because the logic down in histitch() doesn't care, and ISIS histitch doesn't care.

Maybe there's some other hidden gotcha that I don't remember, but I think you could just eliminate the check in main(), and then wouldn't need the --nocheck at all.

AndrewAnnex commented 4 years ago

ah, okay I will close this pr for a simpler one