NeoGeographyToolkit / StereoPipeline

The NASA Ames Stereo Pipeline is a suite of automated geodesy & stereogrammetry tools designed for processing planetary imagery captured from orbiting and landed robotic explorers on other planets.
Apache License 2.0
492 stars 173 forks source link

parallel_sfs with --save-dem-with-nodata #346

Closed ryodohemmi closed 2 years ago

ryodohemmi commented 2 years ago

Describe the bug Running parallel_sfs with --save-dem-with-nodata outputs -DEM-nodata-final.tif in individual tiles' (child) directories correctly; but, in a current working (parent) directory, its final (dem-mosaiced) DEM product is -DEM-final.tif, not *-DEM-nodata-final.tif.

To Reproduce Just apply parallel_sfs --save-dem-with-nodata (with --shadow-thresholds) to multiple LROC NAC images (ISIS cubes).

Expected behavior The final mosaicked DEM(s) should be -DEM-nodata-final.tif or both -DEM-nodata-final.tif and *-DEM-final.tif.

My Environment

Additional context This is not an urgent issue (I can handle it by just applying dem_mosaic to *-DEM-nodata-final.tif in each tile directory afterwards), but a fix will be greatly appreciated.

oleg-alexandrov commented 2 years ago

That was an oversight. I fixed it now. Thank you for the report.

The sfs tool is a bit researchy, still in development, and needs a good speedup (which is planned). So one needs some caution with it. If you manage to do anything useful with it, I would be curious to know. I also see that your interest is in craters. The question of how accurately ASP resolves craters is still something being looked into.

On Wed, Oct 27, 2021 at 10:15 PM ryodohemmi @.***> wrote:

Describe the bug Running parallel_sfs with --save-dem-with-nodata outputs -DEM-nodata-final.tif in individual tiles' (child) directories correctly; but, in a current working (parent) directory, its final (dem-mosaiced) DEM product is -DEM-final.tif, not *-DEM-nodata-final.tif.

To Reproduce Just apply parallel_sfs --save-dem-with-nodata (with --shadow-thresholds) to multiple LROC NAC images (ISIS cubes).

Expected behavior The final mosaicked DEM(s) should be -DEM-nodata-final.tif or both -DEM-nodata-final.tif and *-DEM-final.tif.

My Environment

  • OS: Ubuntu 18.04
  • ASP Version: 3.0.0 (ISIS 5.0.1)

Additional context This is not an urgent issue (I can handle it by just applying dem_mosaic to *-DEM-nodata-final.tif in each tile directory afterwards), but a fix will be greatly appreciated.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/NeoGeographyToolkit/StereoPipeline/issues/346, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAKDU3DX64WJGAXS2FDKC3TUJDL6XANCNFSM5G36LH5Q . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.