search

NeoGeographyToolkit / StereoPipeline

The NASA Ames Stereo Pipeline is a suite of automated geodesy & stereogrammetry tools designed for processing planetary imagery captured from orbiting and landed robotic explorers on other planets.
Apache License 2.0
478 stars 168 forks source link

Precompiled binary build environment leaking #397

Closed AndrewAnnex closed 1 year ago

AndrewAnnex commented 1 year ago

Describe the bug

The precompiled binary distribution of ASP has leaks of the conda environment used for building. A majority of the scripts in bin contain references to /home/oalexan1/miniconda3/envs/python_isis7 in the shebangs and etc. This is a fairly minor issue perhaps but something to look into scrubbing

Your Environment (please complete the following information): ASP 3.2.1-alpha (a nightly build from last week)

oleg-alexandrov commented 1 year ago

All those paths pointing to my build dir are created by conda, indeed. Apart from what is in bin/, there's zillions of them in the lib dir, because ASP has to ship a whole Python due to ISIS requirements.

I added a cleanup step. Any local path on my build system that has a /bin, /lib, /libexec, etc as part of its name will be replaced with the corresponding /usr path. That new path may not exist on your system, such as /usr/bin/python36, but my own path surely doesn't exist either.

There are a few quirky files having my local path which do not correspond to either a library or a binary, in some obscure config files that aren't used, such as for tk, pkgconfig, etc, that I left alone.