search

NeoGeographyToolkit / StereoPipeline

The NASA Ames Stereo Pipeline is a suite of automated geodesy & stereogrammetry tools designed for processing planetary imagery captured from orbiting and landed robotic explorers on other planets.
Apache License 2.0
478 stars 168 forks source link

hiedr2mosaic.py divergent between conda and release build #406

Closed Hyradus closed 11 months ago

Hyradus commented 11 months ago

Describe the bug We noticed that the hiedr2mosaic.py provided by the github release build is different from the one provided by conda installation.

edited after additional findings

In detail: a "--web" option has been added hiedr2mosaic.py in ASP 3.1.0, to be used by spiceinit. 3.1.0 release notes

So ti seems that the daily build has the option but the version builds not.

To Reproduce Steps to reproduce the behavior: Install ASP using conda channel nasa-ames-stereo-pipeline or Use precompiled binaries 3.1.0, 3.2.0

Expected behavior hiedr2mosaic.py should accept --web option

Your Environment (please complete the following information):

Additional context I don't know how conda builds are made, but I think it may be a problem to have divergent versions.

rbeyer commented 11 months ago

The --web option has been added to the "Changes since last release" notes after the 3.2.0 release, and the changes to the codebase that added it were made in January 2023. It is not in the 3.1.0 release notes (released May 2022) nor in the 3.2.0 release notes (December 2022) because the changes occurred after those releases. The NEWS file is constructed in reverse chronological order such that the most recent things are at the top and the oldest items are at the bottom.

This feature has been added to the codebase, but is not yet present in a versioned release, so your observation that "the daily build has the option but the version builds not" is absolutely correct, and not at all divergent.

Hyradus commented 11 months ago

Ahhh! Got it, thanks! My understanding of the release notes order was completely divergent :)
Is there a timeline for the next complete release?

oleg-alexandrov commented 11 months ago

Not sure about when we'll have an official release. Sometimes this Fall, before October, even. The daily build seems to be working reasonably well as a snapshot of latest functionality.

On Fri, Jul 21, 2023 at 7:45 AM Giacomo Nodjoumi @.***> wrote:

Ahhh! Got it, thanks! My understanding of the release notes order was completely divergent :) Is there a timeline for the next complete release?

— Reply to this email directly, view it on GitHub https://github.com/NeoGeographyToolkit/StereoPipeline/issues/406#issuecomment-1645706953, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAKDU3HVUCYCKERYITYYFJDXRKIZTANCNFSM6AAAAAA2SYIYJQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>

Hyradus commented 11 months ago

@oleg-alexandrov ok thanks for the info! I'll close this. Thanks again!