NeoGeographyToolkit / StereoPipeline

The NASA Ames Stereo Pipeline is a suite of automated geodesy & stereogrammetry tools designed for processing planetary imagery captured from orbiting and landed robotic explorers on other planets.
Apache License 2.0
491 stars 172 forks source link

Change 'no stereo.default file' handling. #53

Closed rbeyer closed 11 years ago

rbeyer commented 11 years ago

If there is no ./stereo.default file, stereo complains and will not run. Is this intended behavior? Two alternatives:

  1. If no ./stereo.default file is found, automatically assume the default settings, full auto, and go to town.
  2. If there is no ./stereo.default file found, the user should be asked if they want to continue with default settings, or not. If not, stereo quits.

Without these, I have to track down a default stereo.default file to put in my CWD to run stereo, even when I just want to take all the default parameters. I'm probably just being too lazy?

zmoratto commented 11 years ago

Extremely Lazy. :P

I like the idea of #2. Only difficulty I see is the writing of -stereo.default which is for the user's record keeping. Currently we just copy their file over and write a little extra on the first line.

oleg-alexandrov commented 11 years ago

I like #1 though. We are aiming for the software to do mass-processing of images. It is better if it goes with default settings (and give a warning) rather than always stall asking the user (image 100 jobs on the supercomputer waiting for user to say yes/no). I don't think anywhere in ASP we ask user for interactive input, and starting here would not be so helpful I'd say.

On Sun, Apr 28, 2013 at 11:18 AM, Zack Moratto notifications@github.comwrote:

Extremely Lazy. :P

I like the idea of #2https://github.com/NeoGeographyToolkit/StereoPipeline/issues/2. Only difficulty I see is the writing of -stereo.default which is for the user's record keeping. Currently we just copy their file over and write a little extra on the first line.

— Reply to this email directly or view it on GitHubhttps://github.com/NeoGeographyToolkit/StereoPipeline/issues/53#issuecomment-17139324 .

zmoratto commented 11 years ago

Okay. I see your point. Let's do #1.

dshean commented 11 years ago

+1

I think nearly all of the stereo.default options are available as command line options at this point (?), and I might even say the stereo.default file is obsolete.

Maybe a centralized ~/stereo.default could allow the user to override hardcoded defaults? I would even favor abandoning the 'stereo.default' filename for ~/.asprc

In my opinion, the copied outprefix-stereo.default file was never all that useful, as it only included the most recent command followed by the contents of the stereo.default file. My existing scripts always selected one of several centralized stereo.default files and copied locally before running ASP. But now I override most settings w/ command line options.

At some point, it could be more useful to produce a log file with diagnostic information (e.g, IP detection/matching stats and the detected/refined search windows). The only way to capture this information with the current code is to pipe stdout to a log file.

oleg-alexandrov commented 11 years ago

I put a fix. If the tool cannot find the stereo.default file specified by the user, it will print a warning and move on. Note that this behavior will apply even if you did specify a stereo.default file but with a mis-spelled name, or which is in some other directory.

The tool will, as always, create a backup stereo.default file in the run directory, but it will be empty, it will only have at the top the command which was used to invoke the tool.