search

NeoGeographyToolkit / synthterrain

Tools for the generation of synthetic planetary terrain
Apache License 2.0
4 stars 0 forks source link

synthcraters --bbox not working as intended #5

Closed rbeyer closed 2 years ago

rbeyer commented 2 years ago

It appears that synthcraters is not respecting the --bbox argument.

When --bbox -1054.500 -1373.500 387.500 56.500 is given, which should match the area of this map: MicrosoftTeams-image

The returned craters are not in that area, but in a square area.

rbeyer commented 2 years ago

The bounding box, as defined: -bbox -1054.500 -1373.500 387.500 56.500 is 1442 m wide by 1430 m tall, which is pretty squarish, so I think that synthcraters is doing what is being asked of it. Maybe we need to evaluate how the bounding box values are extracted from this map?

rbeyer commented 2 years ago

This error was from a data entry mis-understanding, but the format that we take bbox entries is lower-left upper-right, and it was pointed out that the GDAL pattern is upper-left lower-right. So changing to the GDAL pattern is probably going to be best for interoperability, and user interface.