search

NeoGeographyToolkit / synthterrain

Tools for the generation of synthetic planetary terrain
Apache License 2.0
4 stars 0 forks source link

Proper limit of crater diameter range #6

Closed rbeyer closed 2 years ago

rbeyer commented 2 years ago

This PR would close #3 and #4.

The fundamental problem with #3 was that truly any positive value could be "drawn" from the underlying distribution. It was more likely that the values would be drawn from the area between the supports of the distribution, but values outside that range were possible, and in the example given, when hundreds of thousands of draws were made, about 10 resulted in diameters so much larger than 10 m in diameter that the Grun function just wasn't mathematically correct out there, and resulted in negative ages, and hence the error.

Fixing that issue to limit the range over which crater diameters were selected also turned out to be exactly what was needed to address #4.

rbeyer commented 2 years ago

Fun with natural language parsing. The initial comment only had GitHub put the "auto close" connection on #3. But now if I say that this PR will close #4, does that alter things, or do I need to alter the initial comment?