Disallow of addition of people with the same name

[NeoHW]

Reason for severity: In the real world, people can have the same name. E.g Tan Xin Yi. This should be allowed in the app too. It does not make sense for people with the same name to not be allowed to be added into the app. In cases of high density of population areas where common names can have up to 1000 occurrences in a city, only 1 out of 1000 can be added into the app

1. add n/Derek Lau p/123456789 e/dlau@example.com
2. add n/Derek Lau p/12345678999 e/dldsadsaau@example.com

[nus-pe-bot]

Team's Response

We addressed this in our DG.

We suggest the severity to be lowered from high to low because this is not very common in real life. Furthermore, one can use alphanumeric characters to differentiate people with the same name.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Names overly restrictive

Only allowing alpha numeric characters in names is overly restrictive, many legal names exist where '/' are needed. some non alphanumeric characters should be accepted.

Steps to reproduct:

1. Run in CLI ' add n/John s/o Doe p/98765432 e/johnd@example.com a/311, Clementi Ave 2, #02-25 k/Joe s/o Doe d/Has a history of memory loss t/mentalIllness t/owesMoney'

Expected output: User added

Actual output: Error non alphanumeric names

---

_{[original: nus-cs2103-AY2324S2/pe-interim#1534] [original labels: type.FunctionalityBug severity.Low]}

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

In our DG, we mentioned that this is a known issue and we are planning to implement this functionality in future iterations. Hence, we would like to reject this bug.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

• [x] I disagree

Reason for disagreement:

1. Checking for special characters using regex is not the same as ensuring names should be unique
2. Fixing the names to accept "/" does not fix the issue where names are the same

---

## :question: Issue response Team chose [`response.Rejected`] - [x] I disagree **Reason for disagreement:** In their planned enhancments: Proposed to have regex changes for more flexible names, e.g. allowing '/' character. However, the issue here is that names must be unique. Allowing for a '/' character in planned enhancement does not fix the issue that there are people with same names (e.g. Tan Xin Yi) which cannot be added into the app.

---

## :question: Issue type Team chose [`type.FunctionalityBug`] Originally [`type.FeatureFlaw`] - [x] I disagree **Reason for disagreement:** Dev team did not specify reason for choosing Functionality bug instead of FeatureFlaw. It is a FeatureFlaw as the ability to support people with the same names is missing from the application. There is a missing feature and a problem in how the feature is designed, which makes the app less useful.

---

## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.High`] - [x] I disagree **Reason for disagreement:** The dev team reason for low is responding to the other issue where the issues lies with the special character '/'. There is **no mention of reasoning or justification** on why the severity should be low for the issue of unique names hindering the addition of multiple people. As stated in the original bug report: > In the real world, people can have the same name. E.g Tan Xin Yi. This should be allowed in the app too. It does not make sense for people with the same name to not be allowed to be added into the app. In cases of high density of population areas where common names can have up to 1000 occurrences in a city, only 1 out of 1000 can be added into the app. Furthermore, the goal of the app is to help social worker with high caseloads. When there are high caseloads, the chance of having 2 people with the same name **increases exponentially**. Most social workers would run into this problem and it would cause major problems for users. Especially when they can only add one person out of many into the application, making it **almost unusable for most users**. 

---