search

NeoLegends / velocity-pwa

🚴‍♂️💨 An alternative https://velocity-aachen.de/menu
3 stars 3 forks source link

Add „Refresh booking“ button #15

Closed LucasForster closed 5 years ago

LucasForster commented 5 years ago

This pull request addresses #14.

I contains the following changes:

NeoLegends commented 5 years ago

Can you merge master & resolve the conflicts? I have added a hook function that is responsible for booking the bike & updating the hook state accordingly. This conflicts with the refresh function.

LucasForster commented 5 years ago

@NeoLegends Please resolve the last 4 open conversations if appropriate. If there's something missing, please specify what exactly needs to be changed.

I'm going to work on the UI now (oldest open conversation).

LucasForster commented 5 years ago

Currently the rent popup isn't updated when a booking is refreshed. It works when canceling the booking, so I'll search for the difference.

NeoLegends commented 5 years ago

Another thought of mine: does the "counter" refresh? Seems like it shows the remaining duration, but the value is only refreshed when opening & closing the popup. Maybe we'd just want to run a timer that keeps the remaining duration current? This might also solve our issues with a booking that has timeouted and the user pressing the refresh button.

LucasForster commented 5 years ago

Another thought of mine: does the "counter" refresh?

I thought of the same thing, but then I saw that it actually does. I think this is due to useIntervall(fetchbooking).