search

NeoLegends / velocity-pwa

🚴‍♂️💨 An alternative https://velocity-aachen.de/menu
3 stars 3 forks source link

Displaying station note/motd in rent-popup #19

Closed sudmann closed 5 years ago

sudmann commented 5 years ago

This PR resolves https://github.com/NeoLegends/velocity-pwa/issues/16. :tada:

I wasn't sure if the .note class in scss/_note.scss was intended for this kind of text. The margins/paddings seemed a little too big so I decided to just wrote a separate class to the rent-popup stylesheet. We can change that easily with adding a separator to .note of course. So please also provide some feedback on this.

If you can't find a station with a note: StreetScooter (Jülicher Str.)

sudmann commented 5 years ago

I've made the JSX renders only if there is a station note, as requested.

There is some conflict in the stylesheet due to newer commits on the master. I tried to fix it without fetching the new commits but that didn't seem to work. So I'm just leaving it as it is right now.