search

NeoLegends / velocity-pwa

🚴‍♂️💨 An alternative https://velocity-aachen.de/menu
3 stars 3 forks source link

Reloading causes slight shift in map #30

Closed Empty2k12 closed 5 years ago

Empty2k12 commented 5 years ago

Reloading the page causes a slight shift when the map position is loaded from localStorage.

Research solutions that prevent this from happening.

Empty2k12 commented 5 years ago

Bug in Action!

NeoLegends commented 5 years ago

Yeah this is something with leaflet-react. I just tried using useLayoutEffect for loading the cached viewport, but that didn't change anything. So I figure I'll just leave it as it is right now. If you want to take a look at it, PRs welcome (especially since you have experience with caching the viewport and feeding it to leaflet-react in a proper way).

Empty2k12 commented 5 years ago

Why close it then? Mark as bug and good-first-issue and you're golden.