NeoLegends / velocity-pwa

🚴‍♂️💨 An alternative https://velocity-aachen.de/menu
3 stars 3 forks source link

Refactor popup logic #5

Closed NeoLegends closed 5 years ago

NeoLegends commented 5 years ago

Booking & renting logic is currently split between the bike-map and rent-popup components. This creates some complications in regards to clear separation of concerns. We should move the booking & renting logic into rent-popup entirely.

LucasForster commented 5 years ago

Basically, you would remove the "Active reservation" field from the "Bookings"-tab.

It contains the following information which needs to be integrated into the rent-popup:

NeoLegends commented 5 years ago

Basically, you would remove the "Active reservation" field from the "Bookings"-tab.

Nah, this ticket is solely related to the code base, not to anything user-related.

NeoLegends commented 5 years ago

I'm open to making the rent popup take over the responsibilities of the bookings tab in regards to the currently active booking, but let's create a separate issue for that.