NeoLegends / velocity-pwa

🚴‍♂️💨 An alternative https://velocity-aachen.de/menu
3 stars 3 forks source link

Booking is broken #51

Closed Empty2k12 closed 3 years ago

Empty2k12 commented 3 years ago

It seems there was a regression introduced in #48 which renders Velocity.ac unable to rent bikes.

Sadly, there's no more information available about this issue as it only happens when you're at a station actually trying to rent a bike which mostly happens on mobile devices with limited debugging tooling available.

NeoLegends commented 3 years ago

Velo re-enters bikes that haven't been taken out of the station into the system after 30s. So you could, for example, try renting a bike from home at a remote station and debug on that.

Empty2k12 commented 3 years ago

Velo re-enters bikes that haven't been taken out of the station into the system after 30s. So you could, for example, try renting a bike from home at a remote station and debug on that.

Sadly, this behaviour changed since the smart-locks have been introduced: The renting procedure will first unlock the smart-lock, if that was successful release the bike from the station. Thus, if you rent, the smart-lock will open and since you cannot remotely close it stay open and the bike will display as reserved at the station until someone closes the smart lock.

Additionally, this is quite unsafe. The bike was only reaccepted if all contacts were still touching the station. I have seen countless occasions in the field where a bike would start moving when released from the station, up to the point sliding out and falling over.

NeoLegends commented 3 years ago

Oh gosh. Perhaps we'll have to do some field-work in the next week.

Empty2k12 commented 3 years ago

This has been resolved in #52