NeoLegends / velocity-pwa

🚴‍♂️💨 An alternative https://velocity-aachen.de/menu
3 stars 3 forks source link

More detailed tariff info when exotic tariff is booked #53

Open Empty2k12 opened 3 years ago

Empty2k12 commented 3 years ago

The tariff overview page lists only the publicly bookable tarifs: https://cms.velocity-aachen.de/backend/app/tariffs

However, when a user has another tariff activated like

https://cms.velocity-aachen.de/backend/app/tariffs/7 {"tariffId":7,"name":"Velo30Coupon","description":"Gutschein, Abo mit 30 Tagen Laufzeit und Freiminuten, nicht verlängerbar","term":30,"periodicRate":0,"priceList":[]}

https://cms.velocity-aachen.de/backend/app/tariffs/8 {"tariffId":8,"name":"FreeTariff","description":"Null-Tarif","term":0,"periodicRate":0,"priceList":[]}

https://cms.velocity-aachen.de/backend/app/tariffs/9 {"tariffId":9,"name":"TouristTariff","description":"Tagesticket","term":1,"periodicRate":0,"priceList":[]}

the find() function here fails, causing these to display "N/A" as the description, even though it were available when the corrent detail page was queried for the correct field.

This ticket is more of a future-proofing, as real-world users are unlikely to run into this problem unless there's a special tariff booked for their account.